Closed Bug 513170 Opened 15 years ago Closed 6 years ago

[Windows] Drawing personas under Aero Glass in Firefox 4

Categories

(Firefox :: General, defect)

x86
Windows Vista
defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: faaborg, Unassigned)

References

Details

Attachments

(2 files)

An additional consideration beyond the things covered in bug 513162 (Drawing in the Title Bar for Firefox 4), we may also want to mix drawing a persona with Aero Glass support.

In this model there would theoretically be the following layers:

1) user's desktop or background windows
2) persona image, which may or may not contain an alpha channel
3) aero glass
4) window foreground (tabs, toolbars, etc.)

It's entirely possible that there is no way to achieve this, in which case we we will likely need to fall back to glass like images overlaying the persona in combination with bug 513162 allowing us to draw in the title bar.
If you draw the image with alpha, it will blend with the glass effect but the actual layers are 1, 3, 2, 4 and we only have control over 2,4.
Blocks: 546831
Summary: Drawing personas under Aero Glass in Firefox 4 → [Windows] Drawing personas under Aero Glass in Firefox 4
Blocks: 567771
No longer blocks: 567771
Depends on: 575406, 574833
Depends on: 578924
Depends on: 590945
If i apply any persona, the persona covers the top border of the browser window. This make the feel that the Fx button is "floating". (Actually it is 5px down from the edge = covered border's width.)
Attachment #470418 - Attachment description: Persona covers window border → Persona covers top border of window
Persona covering title bar is normal, it will be covering all edges when this lands. Shouldn't be this issue fixed in bug 574681?
From bug 574681:

(In reply to comment #67)
> (In reply to comment #64)
> > 
> > 
> > The issue is related to the title bar, not the Firefox button itself. The
> > problem is that the Persona is covering the border of the window, and needs to
> > be moved down by about 2 pixels.
> 
> Should i report it to another bug? If yes, wich one?

Most likely bug 513170. ;-)
(In reply to comment #3)
> Created attachment 470418 [details]
> Persona covers top border of window
> 
> If i apply any persona, the persona covers the top border of the browser
> window. This make the feel that the Fx button is "floating". (Actually it is
> 5px down from the edge = covered border's width.)

(In reply to comment #4)
> Persona covering title bar is normal, it will be covering all edges when this
> lands. Shouldn't be this issue fixed in bug 574681?

(In reply to comment #5)
> From bug 574681:
> 
> (In reply to comment #67)
> > (In reply to comment #64)
> > > 
> > > 
> > > The issue is related to the title bar, not the Firefox button itself. The
> > > problem is that the Persona is covering the border of the window, and needs to
> > > be moved down by about 2 pixels.
> > 
> > Should i report it to another bug? If yes, wich one?
> 
> Most likely bug 513170. ;-)

Filed bug 591930 - "Persona background is drawn too high in titlebar"
Depends on: 597921
No longer depends on: 597921
Is this still an issue?
(In reply to Michael Kaply (mkaply) from comment #7)
> Is this still an issue?

On Windows this is held up by bug 590945, which is held up by bug 672885, which looks to be unfixable.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: